Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new material comparison script #3389

Merged
merged 10 commits into from
Jul 19, 2024
Merged

feat: new material comparison script #3389

merged 10 commits into from
Jul 19, 2024

Conversation

asalzburger
Copy link
Contributor

@asalzburger asalzburger commented Jul 15, 2024 •
edited
Loading

This PR overwrites the material comparison script, that was based on ROOT with an uproot version.

As one can see here: the Gen2 navigation still needs debugging!

MaterialComparison

@asalzburger asalzburger added this to the next milestone Jul 15, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Jul 15, 2024
@asalzburger
Copy link
Contributor Author

@benjaminhuth - be critical and teach me better python !

benjaminhuth
benjaminhuth previously approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a lot to critisize from my perspective - looks like proper python code to me! I only have a few minor comments.

Examples/Scripts/MaterialMapping/material_comparison.py Outdated Show resolved Hide resolved
Examples/Scripts/MaterialMapping/material_comparison.py Outdated Show resolved Hide resolved
Examples/Scripts/MaterialMapping/material_comparison.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

📊: Physics performance monitoring for d830878

Full contents

physmon summary

@asalzburger
Copy link
Contributor Author

Hey @benjaminhuth - can you have a second look?

benjaminhuth
benjaminhuth approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andiwand
Copy link
Contributor

removing automerge so we can cut v36

@paulgessinger paulgessinger modified the milestones: next, v36.0.0 Jul 18, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit e754bf8 into acts-project:main Jul 19, 2024
46 checks passed
@acts-project-service
Copy link
Collaborator

acts-project-service commented Jul 19, 2024 •
edited
Loading

✅ Athena integration test results [e754bf8]

✅ All tests successful

status job report
🟢 report_pull_request
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco
🟢 test_ActsDumpGeometryIdentifiers
🟢 test_ActsCheckObjectCountsWorkflow
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🟢 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsWorkflowHeavyIons
🟢 test_ActsWorkflowFastTracking
🟢 test_ActsWorkflowCached
🟢 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🟢 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🟢 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_unit_tests

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Jul 19, 2024
@paulgessinger paulgessinger modified the milestones: next, v36.1.0 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminhuth benjaminhuth benjaminhuth approved these changes

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Component - Examples Affects the Examples module
Projects
None yet
Milestone
v36.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@asalzburger @andiwand @acts-project-service @benjaminhuth @paulgessinger